Re: [PATCH netdev] net: stmmac: dwmac-rk: Don't fail if phy regulator is absent
From: David Miller
Date: Fri Aug 30 2019 - 17:17:31 EST
From: Chen-Yu Tsai <wens@xxxxxxxxxx>
Date: Thu, 29 Aug 2019 11:17:24 +0800
> From: Chen-Yu Tsai <wens@xxxxxxxx>
> The devicetree binding lists the phy phy as optional. As such, the
> driver should not bail out if it can't find a regulator. Instead it
> should just skip the remaining regulator related code and continue
> on normally.
> Skip the remainder of phy_power_on() if a regulator supply isn't
> available. This also gets rid of the bogus return code.
> Fixes: 2e12f536635f ("net: stmmac: dwmac-rk: Use standard devicetree property for phy regulator")
> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx>
Applied and queued up for -stable.
> On a separate note, maybe we should add this file to the Rockchip
> entry in MAINTAINERS?