Re: [PATCH v2] vsprintf: introduce %dE for error constants
From: Rasmus Villemoes
Date: Fri Aug 30 2019 - 17:45:48 EST
On 29/08/2019 19.39, Uwe Kleine-KÃnig wrote:
> On 8/29/19 11:09 AM, Rasmus Villemoes wrote:
>> still prefer making it %pE, both because it's easier to convert integers
>> to ERR_PTRs than having to worry about the type of PTR_ERR() being long
>> and not int, and because alphanumerics after %p have been ignored for a
>> long time (10 years?) whether or not those characters have been
>> recognized as a %p extension, so nobody relies on %pE putting an E after
>> the %p output. It also keeps the non-standard extensions in the same
>> "namespace", so to speak.
>> Oh, 'E' is taken, well, make it 'e' then.
> I like having %pe to print error valued pointers. Then maybe we could
> have both %de for ints and %pe for pointers. :-)
Oh no. And actually, come to think of it, we don't even need to extend
%p at all (taking away yet another letter for future expansion...), we
should simply make %p DTRT when passed an ERR_PTR - currently, if it's
some %p<extension> that would normally derefence it, there's sanity
checking in place which makes it print (efault), while if it's plain %p,
it just does the hashing, making it impossible to figure out that it was
an errno value (or which it was).
I've cooked up what I mean, sending in separate thread.