Re: [PATCH v2 7/9] sparc64: numa: check the node id consistently for sparc64

From: Yunsheng Lin
Date: Sat Aug 31 2019 - 04:57:50 EST

On 2019/8/31 14:53, David Miller wrote:
> From: Yunsheng Lin <linyunsheng@xxxxxxxxxx>
> Date: Sat, 31 Aug 2019 13:58:21 +0800
>> According to Section 6.2.14 from ACPI spec 6.3 [1], the setting
>> of proximity domain is optional, as below:
> What in the world does the ACPI spec have to do with sparc64 NUMA
> node ID checking?

I am not sure I understand your question fully here.

Here is my issue when the bios does not implement the proximity domain
of a device because the feature is optional according to the ACPI spec,
the dev_to_node(dev) return -1, which causes out of bound access when
using the value to get the device's cpu mask by calling cpumask_of_node.

Did you mean sparc64 system does not has ACPI, the device's node id will
not specified by ACPI, so the ACPI is unrelated here?

Or did you mean the commit log is not clear enough to justify the change?

Or did you mean this problem should be fixed in somewhere else?

Any detail advice and suggestion will be very helpful, thanks.

> .