Re: [PATCH v3 06/11] wimax/i2400m: remove unlikely() from WARN*() condition

From: Markus Elfring
Date: Sat Aug 31 2019 - 07:25:54 EST


pad_buf = i2400m_tx_fifo_push(i2400m, padding, 0, 0);
- if (unlikely(WARN_ON(pad_buf == NULL
- || pad_buf == TAIL_FULL))) {
+ if (WARN_ON(pad_buf == NULL || pad_buf == TAIL_FULL)) {

How do you think about to use the following code variant?

+ if (WARN_ON(!pad_buf || pad_buf == TAIL_FULL)) {


Regards,
Markus