Re: [PATCH net] rxrpc: Fix lack of conn cleanup when local endpoint is cleaned up [ver #2]

From: David Howells
Date: Sun Sep 01 2019 - 03:15:01 EST

Hillf Danton <hdanton@xxxxxxxx> wrote:

> > It's certainly possible that that can happen. The reaper is per
> > network-namespace.
> >
> > conn->params.local holds a ref on the local endpoint.
> >
> Then local endpoint can not become dead without connection reaper
> running first, because of the ref held by connection. When it is
> dead, however, there is no need to run reaper directly (rather than
> through a workqueue).

The reaper is per-net_ns, not per-local. There may be more than one local
endpoint in a net_ns and they share the list of service connections.