Re: [PATCH] iio: adc: meson_saradc: Fix memory allocation order

From: Martin Blumenstingl
Date: Sun Sep 01 2019 - 07:29:34 EST


On Sun, Sep 1, 2019 at 12:45 PM Remi Pommarel <repk@xxxxxxxxxxxx> wrote:
>
> meson_saradc's irq handler uses priv->regmap so make sure that it is
> allocated before the irq get enabled.
>
> This also fixes crash when CONFIG_DEBUG_SHIRQ is enabled, as device
> managed resources are freed in the inverted order they had been
> allocated, priv->regmap was freed before the spurious fake irq that
> CONFIG_DEBUG_SHIRQ adds called the handler.
>

Fixes: 3af109131b7eb8 ("iio: adc: meson-saradc: switch from polling to
interrupt mode")
> Reported-by: Elie Roudninski <xademax@xxxxxxxxx>
> Signed-off-by: Remi Pommarel <repk@xxxxxxxxxxxx>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>

thank you for fixing this!


Martin