Re: [PATCH v3] libnvdimm: Enable unit test infrastructure compile checks
From: Jason Gunthorpe
Date: Mon Sep 02 2019 - 02:22:29 EST
On Sat, Aug 31, 2019 at 11:52:47AM -0700, Dan Williams wrote:
> The infrastructure to mock core libnvdimm routines for unit testing
> purposes is prone to bitrot relative to refactoring of that core.
> Arrange for the unit test core to be built when CONFIG_COMPILE_TEST=y.
> This does not result in a functional unit test environment, it is only a
> helper for 0day to catch unit test build regressions.
> Note that there are a few x86isms in the implementation, so this does
> not bother compile testing this architectures other than 64-bit x86.
> Cc: JÃrÃme Glisse <jglisse@xxxxxxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> Reported-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Link: https://lore.kernel.org/r/156097224232.1086847.9463861924683372741.stgit@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Changes since v2:
> - Fixed a 0day report when the unit test infrastructure is built-in.
> Arrange for it to only compile as a module. This has received a build
> success notifcation from the robot over 142 configs.
> Hi Jason,
> As we discussed previously please take this through the hmm tree to give
> compile coverage for devm_memremap_pages() updates.
Okay, applied again and 0-day passed