Re: [PATCH v6 01/24] erofs: add on-disk layout

From: Gao Xiang
Date: Mon Sep 02 2019 - 06:36:10 EST


Hi Pavel,

(Thanks...)

On Mon, Sep 02, 2019 at 10:40:20AM +0200, Pavel Machek wrote:

>
> So __packed is right thing to do. If architecture accesses that
> slowly, that's ungood, but different structures between architectures
> would be really bad.

(...a little word, it seems that Christoph was trying to say that
it's unnecessary to __packed for this case since we designed most
erofs on-disk format in natural alignment... Anyway, I updated,
that seems okay...)

Thanks,
Gao Xiang

>
> Best regards,
> Pavel
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany