Re: [PATCH v2 1/2] gpio: acpi: add quirk to override GpioInt polarity
From: Andy Shevchenko
Date: Mon Sep 02 2019 - 12:06:13 EST
On Mon, Sep 02, 2019 at 03:36:24PM +0200, Linus Walleij wrote:
> On Mon, Sep 2, 2019 at 12:01 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Sat, Aug 31, 2019 at 11:09:14AM +0800, Peter Cai wrote:
> > > On GPD P2 Max, the firmware could not reset the touch panel correctly.
> > > The kernel needs to take on the job instead, but the GpioInt definition
> > > in DSDT specifies ActiveHigh while the GPIO pin should actually be
> > > ActiveLow.
> > >
> > > We need to override the polarity defined by DSDT. The GPIO driver
> > > already allows defining polarity in acpi_gpio_params, but the option is
> > > not applied to GpioInt.
> > >
> > > This patch adds a new quirk that enables the polarity specified in
> > > acpi_gpio_params to also be applied to GpioInt.
> > Thank you for an update!
> > Acked-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > on the condition that Dmitry and other input / Goodix developers are okay with
> > the approach in general.
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> In case Dmitry needs to merge this.
> Or should I simply merge this patch to the GPIO tree?
For my opinion Input subsystem should decide how to proceed with this.
With Best Regards,