Re: [PATCH] iio: adc: meson_saradc: Fix memory allocation order
From: Elie Roudninski
Date: Mon Sep 02 2019 - 16:41:05 EST
On Sun, Sep 1, 2019 at 12:29 PM Martin Blumenstingl
> On Sun, Sep 1, 2019 at 12:45 PM Remi Pommarel <repk@xxxxxxxxxxxx> wrote:
> > meson_saradc's irq handler uses priv->regmap so make sure that it is
> > allocated before the irq get enabled.
> > This also fixes crash when CONFIG_DEBUG_SHIRQ is enabled, as device
> > managed resources are freed in the inverted order they had been
> > allocated, priv->regmap was freed before the spurious fake irq that
> > CONFIG_DEBUG_SHIRQ adds called the handler.
> Fixes: 3af109131b7eb8 ("iio: adc: meson-saradc: switch from polling to
> interrupt mode")
> > Reported-by: Elie Roudninski <xademax@xxxxxxxxx>
> > Signed-off-by: Remi Pommarel <repk@xxxxxxxxxxxx>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>
> thank you for fixing this!
The patch fixed the kernel panic I had, i can now successfully boot my
meson-gxl-s905x-libretech-cc boad using patched linux 5.2.11
Tested-by: Elie ROUDNINSKI <xademax@xxxxxxxxx>