Re: [PATCH net-next] r8152: modify rtl8152_set_speed function
From: Heiner Kallweit
Date: Tue Sep 03 2019 - 02:13:57 EST
On 03.09.2019 05:16, Hayes Wang wrote:
> Heiner Kallweit [mailto:hkallweit1@xxxxxxxxx]
>> Sent: Tuesday, September 03, 2019 2:37 AM
>> Seeing all this code it might be a good idea to switch this driver
>> to phylib, similar to what I did with r8169 some time ago.
> It is too complex to be completed for me at the moment.
> If this patch is unacceptable, I would submit other
> patches first. Thanks.
My remark isn't directly related to your patch and wasn't
meant as an immediate ToDo. It's just a hint, because I think
using phylib could help to significantly simplify the driver.
> Best Regards,