Re: [PATCH 3/3] dt-bindings: regulator: add regulator-fixed-clock binding
From: Rob Herring
Date: Tue Sep 03 2019 - 04:45:29 EST
On Tue, Sep 3, 2019 at 9:03 AM Philippe Schenker
> This adds the documentation to the compatible regulator-fixed-clock
Please explain what that is in this patch.
> Signed-off-by: Philippe Schenker <philippe.schenker@xxxxxxxxxxx>
> .../bindings/regulator/fixed-regulator.yaml | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
> diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> index a650b457085d..5fd081e80b43 100644
> --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
> @@ -19,9 +19,19 @@ description:
> - $ref: "regulator.yaml#"
> + properties:
> + compatible:
> + contains:
> + const: regulator-fixed-clock
> + required:
> + - clocks
You don't need this.
If you add a new compatible, then this should probably be a new schema
doc. Is the 'gpio' property valid in this case as if a clock is the
enable, can you also have a gpio enable? That said, it seems like the
new compatible is only for validating the DT in the driver. You could
just use a clock if present and default to current behavior if not.
It's not the kernel's job to validate DTs.
> - const: regulator-fixed
> + items:
> + - const: regulator-fixed
> + - const: regulator-fixed-clock
This says you must have 'compatible = "regulator-fixed",
What you want is:
> regulator-name: true
> @@ -29,6 +39,12 @@ properties:
> description: gpio to use for enable control
> maxItems: 1
> + clocks:
> + description:
> + clock to use for enable control. This binding is only available if
> + the compatible is chosen to regulator-fixed-clock. The clock binding
> + is mandatory if compatible is chosen to regulator-fixed-clock.
Need to define how many clocks (maxItems: 1).
> description: startup time in microseconds
> $ref: /schemas/types.yaml#/definitions/uint32