Re: [PATCH v5 00/11] Device property improvements, add %pfw format specifier
From: Joe Perches
Date: Tue Sep 03 2019 - 05:38:55 EST
On Mon, 2019-09-02 at 16:57 +0300, Sakari Ailus wrote:
> Hi all,
> This set adds functionality into the device property API (counting a
> node's parents as well as obtaining its name) in order to support printing
> fwnode names using a new conversion specifier "%pfw". The names that are
> produced are equivalent to its OF counterpart "%pOF" on OF systems for the
> two supported modifiers ("f" and "P").
> Printing a node's name is something that's been available on OF for a long
> time and if something is converted to device property API (such as the
> V4L2 fwnode framework) it always got removed of a nice feature that was
> sometimes essential in debugging. With this set, that no longer is the
Doesn't this still have dependencies on removing all
existing %p[fF] uses?
In Linus' tree:
tools/lib/traceevent/Documentation/libtraceevent-func_apis.txt:or events have "%pF" or "%pS" parameter in its format string. It is common to
tools/lib/traceevent/event-parse.c: if (asprintf(&format, "%%pf: (NO FORMAT FOUND at %llx)\n", addr) < 0)
tools/lib/traceevent/event-parse.c: if (asprintf(&format, "%s: %s", "%pf", printk->printk) < 0)
And these in -next:
drivers/scsi/lpfc/lpfc_hbadisc.c: "3185 FIND node filter %pf DID "
drivers/scsi/lpfc/lpfc_hbadisc.c: "3186 FIND node filter %pf NOT FOUND.\n", filter);
drivers/scsi/lpfc/lpfc_sli.c: "(%d):0307 Mailbox cmd x%x (x%x/x%x) Cmpl %pf "