Re: [PATCH] eeprom: at25: Convert the driver to the spi-mem interface
From: Boris Brezillon
Date: Tue Sep 03 2019 - 11:08:59 EST
On Tue, 3 Sep 2019 17:06:52 +0200
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Thu, Apr 25, 2019 at 9:44 PM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Sat, Mar 30, 2019 at 03:16:37PM +0100, Boris Brezillon wrote:
> > > The AT25 protocol fits pretty well in the spi-mem model. Convert the
> > > at25 spi driver to a spi-mem driver and use the dirmap API instead of
> > > forging SPI messages manually.
> > > This makes the driver compatible with spi-mem-only controllers
> > > (controllers implementing only the spi_mem ops).
> > >
> > > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> > > ---
> > > drivers/misc/eeprom/at25.c | 282 +++++++++++++++++++++++--------------
> > > 1 file changed, 176 insertions(+), 106 deletions(-)
> > Will there be a new version of this to fix up the problems that 0-day
> > found in it?
> gmail-whitespace-damaged fix:
> diff --git a/drivers/misc/eeprom/Kconfig b/drivers/misc/eeprom/Kconfig
> index f2abe27010eff133..98145d7d43d0c728 100644
> --- a/drivers/misc/eeprom/Kconfig
> +++ b/drivers/misc/eeprom/Kconfig
> @@ -36,6 +36,7 @@ config EEPROM_AT25
> depends on SPI && SYSFS
> select NVMEM
> select NVMEM_SYSFS
> + select SPI_MEM
> Enable this driver to get read/write support to most SPI EEPROMs,
> after you configure the board init code to know about each eeprom
> Boris: what's the plan?
Sorry, I don't have time to respin this patch. Feel free to send a new
version if you need it.