Re: [PATCH 3/4] remoteproc: don't allow modular build
From: Bjorn Andersson
Date: Tue Sep 03 2019 - 17:07:45 EST
On Mon 02 Sep 13:07 PDT 2019, Christoph Hellwig wrote:
> Remoteproc started using dma_declare_coherent_memory recently, which is
> a bad idea from drivers, and the maintainers agreed to fix that. But
> until that is fixed only allow building the driver built in so that we
> can remove the dma_declare_coherent_memory export and prevent other
> drivers from "accidentally" using it like remoteproc. Note that the
> driver would also leak the declared coherent memory on unload if it
> actually was built as a module at the moment.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
Please pick this together with the other patches.
> drivers/remoteproc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 28ed306982f7..94afdde4bc9f 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -2,7 +2,7 @@
> menu "Remoteproc drivers"
> config REMOTEPROC
> - tristate "Support for Remote Processor subsystem"
> + bool "Support for Remote Processor subsystem"
> depends on HAS_DMA
> select CRC32
> select FW_LOADER