Re: [PATCH v2 15/27] drm/dp_mst: Cleanup drm_dp_send_link_address() a bit

From: Dave Airlie
Date: Tue Sep 03 2019 - 17:42:31 EST

On Wed, 4 Sep 2019 at 06:48, Lyude Paul <lyude@xxxxxxxxxx> wrote:
> Declare local pointer to the drm_dp_link_address_ack_reply struct
> instead of constantly dereferencing it through the union in
> txmsg->reply. Then, invert the order of conditionals so we don't have to
> do the bulk of the work inside them, and can wrap lines even less. Then
> finally, rearrange variable declarations a bit.
> Cc: Juston Li <>
> Cc: Imre Deak <imre.deak@xxxxxxxxx>
> Cc: Ville SyrjÃlà <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Harry Wentland <hwentlan@xxxxxxx>
> Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> Signed-off-by: Lyude Paul <lyude@xxxxxxxxxx>

Reviewed-by: Dave Airlie <airlied@xxxxxxxxxx>