Re: [PATCH 8/8] x86/platform/uv: Account for UV Hubless in is_uvX_hub Ops

From: Christoph Hellwig
Date: Wed Sep 04 2019 - 02:52:53 EST

On Tue, Sep 03, 2019 at 11:58:49AM -0700, Mike Travis wrote:
> Those ifdefs are not dead code and are being actively used. Plus UV1
> support is dead and I think the last running system died about a year ago
> and no support or parts are available. So undef'ing these macros will
> simplify and reduce the size of the object code.

I'm not complaining about removing some ifdefs, that is always good.
I complain about keeping the others that are dead. And if Hub 1 is
dead please drop all the checks and support code for it.

A patch against current mainline to show what I mean is below.