Re: [PATCH] ext2: Delete an unnecessary check before brelse()
From: Jan Kara
Date: Wed Sep 04 2019 - 03:23:36 EST
On Tue 03-09-19 14:44:08, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Tue, 3 Sep 2019 14:40:18 +0200
> The brelse() function tests whether its argument is NULL
> and then returns immediately.
> Thus the test around the call is not needed.
> This issue was detected by using the Coccinelle software.
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Thanks. Added to my tree.
> fs/ext2/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index baa36c6fb71e..30c630d73f0f 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -162,8 +162,7 @@ static void ext2_put_super (struct super_block * sb)
> db_count = sbi->s_gdb_count;
> for (i = 0; i < db_count; i++)
> - if (sbi->s_group_desc[i])
> - brelse (sbi->s_group_desc[i]);
> + brelse(sbi->s_group_desc[i]);
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR