Re: [PATCH v3 3/3] Powerpc64/Watchpoint: Rewrite ptrace-hwbreak.c selftest

From: Ravi Bangoria
Date: Wed Sep 04 2019 - 05:11:41 EST

On 8/28/19 11:44 AM, Christophe Leroy wrote:

Le 10/07/2019 Ã 06:54, Ravi Bangoria a ÃcritÂ:
ptrace-hwbreak.c selftest is logically broken. On powerpc, when
watchpoint is created with ptrace, signals are generated before
executing the instruction and user has to manually singlestep
the instruction with watchpoint disabled, which selftest never
does and thus it keeps on getting the signal at the same
instruction. If we fix it, selftest fails because the logical
connection between tracer(parent) and tracee(child) is also
broken. Rewrite the selftest and add new tests for unaligned

On the 8xx, signals are generated after executing the instruction.

Can we make the test work in both case ?

Sure. I don't mind. I guess, it should be trivial to do that.

But I'm still waiting for Mikey / Mpe's replay on actual patches.
Mikey, mpe, is it ok to not ignore actual events but generate false positive events? Is there any other better approach?