Re: [PATCH v4 08/12] scripts: Coccinelle script for namespace dependencies.

From: Masahiro Yamada
Date: Wed Sep 04 2019 - 05:54:18 EST

On Wed, Sep 4, 2019 at 12:07 AM Matthias Maennich <maennich@xxxxxxxxxx> wrote:
> A script that uses the '<module>.ns_deps' files generated by modpost to
> automatically add the required symbol namespace dependencies to each
> module.
> Usage:
> 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define
> 2) Run 'make' (or 'make modules') and get warnings about modules not
> importing that namespace.
> 3) Run 'make nsdeps' to automatically add required import statements
> to said modules.
> This makes it easer for subsystem maintainers to introduce and maintain
> symbol namespaces into their codebase.
> Co-developed-by: Martijn Coenen <maco@xxxxxxxxxxx>
> Signed-off-by: Martijn Coenen <maco@xxxxxxxxxxx>
> Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Matthias Maennich <maennich@xxxxxxxxxx>

Without any correct dependency,
this does not work.

$ make clean; make nsdeps
cat: modules.order: No such file or directory
cat: ./modules.order: No such file or directory

I do not see any point in the Makefile changes.

Best Regards
Masahiro Yamada