Re: [PATCH v3 0/4] Add binder state and statistics to binderfs

From: Greg Kroah-Hartman
Date: Wed Sep 04 2019 - 10:49:08 EST


On Wed, Sep 04, 2019 at 10:20:32AM -0400, Joel Fernandes wrote:
> On September 4, 2019 7:19:35 AM EDT, Christian Brauner
> <christian.brauner@xxxxxxxxxx> wrote:
> >On Tue, Sep 03, 2019 at 09:16:51AM -0700, Hridya Valsaraju wrote:
> >> Currently, the only way to access binder state and
> >> statistics is through debugfs. We need a way to
> >> access the same even when debugfs is not mounted.
> >> These patches add a mount option to make this
> >> information available in binderfs without affecting
> >> its presence in debugfs. The following debugfs nodes
> >> will be made available in a binderfs instance when
> >> mounted with the mount option 'stats=global' or 'stats=local'.
> >>
> >> /sys/kernel/debug/binder/failed_transaction_log
> >> /sys/kernel/debug/binder/proc
> >> /sys/kernel/debug/binder/state
> >> /sys/kernel/debug/binder/stats
> >> /sys/kernel/debug/binder/transaction_log
> >> /sys/kernel/debug/binder/transactions
> >
> >Acked-by: Christian Brauner <christian.brauner@xxxxxxxxxx>
> >
> >Btw, I think your counting is off-by-one. :) We usually count the
> >initial send of a series as 0 and the first rework of that series as
> >v1.
> >I think you counted your initial send as v1 and the first rework as v2.
>
> Which is fine. I have done it both ways. Is this a rule written somewhere?

No where, I can count both ways, it's not a big deal :)

greg k-h