Re: [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts

From: Andrew Lunn
Date: Wed Sep 04 2019 - 10:58:14 EST

On Wed, Sep 04, 2019 at 10:02:54PM +0800, Voon Weifeng wrote:
> From: "Chuah, Kim Tatt" <kim.tatt.chuah@xxxxxxxxx>
> DW EQoS v5.xx controllers added capability for interrupt generation
> when MDIO interface is done (GMII Busy bit is cleared).
> This patch adds support for this interrupt on supported HW to avoid
> polling on GMII Busy bit.
> stmmac_mdio_read() & stmmac_mdio_write() will sleep until wake_up() is
> called by the interrupt handler.
> Reviewed-by: Voon Weifeng <weifeng.voon@xxxxxxxxx>
> Reviewed-by: Kweh, Hock Leong <hock.leong.kweh@xxxxxxxxx>
> Reviewed-by: Ong Boon Leong <>
> Signed-off-by: Chuah, Kim Tatt <kim.tatt.chuah@xxxxxxxxx>
> Signed-off-by: Ong Boon Leong <>
> Signed-off-by: Voon Weifeng <weifeng.voon@xxxxxxxxx>

Hi Voon

It is normal to include a short description of what you changed
between the previous version and this version.

The formatting of this patch also looks a bit odd. Did you use
git format-patch ; git send-email?