Re: drm/amdgpu: remove the redundant null check

From: Markus Elfring
Date: Wed Sep 04 2019 - 13:51:52 EST

> debugfs_remove and kfree has taken the null check in account.
> hence it is unnecessary to check it. Just remove the condition.

How do you think about a wording like the following?

The functions âdebugfs_removeâ and âkfreeâ tolerate the passing
of null pointers. Hence it is unnecessary to check such arguments
around the calls. Thus remove the extra condition check at two places.

> No functional change.

I find this information questionable while it is partly reasonable
according to the shown software refactoring.

Can a subject like â[PATCH] drm/amdgpu: Remove two redundant
null pointer checksâ be nicer here?

Were any source code analysis tools involved for finding
these update candidates?