Re: [PATCH] ext4: Reduce ext4 timestamp warnings

From: Arnd Bergmann
Date: Wed Sep 04 2019 - 16:56:38 EST


On Wed, Sep 4, 2019 at 8:39 PM Andreas Dilger <adilger@xxxxxxxxx> wrote:
>
> On Sep 4, 2019, at 09:02, Deepa Dinamani <deepa.kernel@xxxxxxxxx> wrote:
> >
> > When ext4 file systems were created intentionally with 128 byte inodes,
> > the rate-limited warning of eventual possible timestamp overflow are
> > still emitted rather frequently. Remove the warning for now.
> >
> > Discussion for whether any warning is needed,
> > and where it should be emitted, can be found at
> > https://lore.kernel.org/lkml/1567523922.5576.57.camel@xxxxxx/.
> > I can post a separate follow-up patch after the conclusion.
> >
> > Reported-by: Qian Cai <cai@xxxxxx>
> > Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
>
> I'd be in favor of a severely rare-limited warning in the actual case
> that Y2038 timestamps cannot be stored, but the current message is
> too verbose for now and I agree it is better to remove it while discussions
> on the best solution are underway.
>
> Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>

Agreed completely.

Applied on top of the y2038 branch now, thanks a lot for the update!

This should be part of tomorrow's linux-next then.

Arnd