Re: [PATCH v7 1/6] mm: Adjust shuffle code to allow for future coalescing
From: Dan Williams
Date: Wed Sep 04 2019 - 17:10:30 EST
On Wed, Sep 4, 2019 at 8:10 AM Alexander Duyck
> From: Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx>
> Move the head/tail adding logic out of the shuffle code and into the
> __free_one_page function since ultimately that is where it is really
> needed anyway. By doing this we should be able to reduce the overhead
> and can consolidate all of the list addition bits in one spot.
> While changing out the code I also opted to go for a bit more thread safe
> approach to getting the boolean value. This way we can avoid possible cache
> line bouncing of the batched entropy between CPUs.
The original version of this patch just did the movement, but now the
patch also does the percpu optimization. At this point it warrants
being split into a "move" patch and then "rework". Otherwise the bulk
of the patch is not really well described by the patch title. With the
split there's a commit id for each of the performance improvement
Other than that the percpu logic changes look good to me.