Re: WARNING in hso_free_net_device
From: Stephen Hemminger
Date: Wed Sep 04 2019 - 18:41:45 EST
On Wed, 4 Sep 2019 16:27:50 -0400
Hui Peng <benquike@xxxxxxxxx> wrote:
> Hi, all:
> I looked at the bug a little.
> The issue is that in the error handling code, hso_free_net_device
> the net_device (hso_net->net)Â by calling unregister_netdev. In the
> error handling code path,
> hso_net->net has not been registered yet.
> I think there are two ways to solve the issue:
> 1. fix it in drivers/net/usb/hso.c to avoiding unregistering the
> net_device when it is still not registered
> 2. fix it in unregister_netdev. We can add a field in net_device to
> record whether it is registered, and make unregister_netdev return if
> the net_device is not registered yet.
> What do you guys think ?