Re: [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts
From: Andrew Lunn
Date: Thu Sep 05 2019 - 02:40:09 EST
> The change log is near the end of the patch:
> Changelog v2
> *mdio interrupt mode or polling mode will depends on mdio interrupt enable bit
> *Disable the mdio interrupt enable bit in stmmac_release
> *Remove the condition for initialize wait queues
> *Applied reverse Christmas tree
At the end, nobody sees it, because everybody else does it at the beginning.
This talks about the ---. David prefers to see the change log before
the ---. Other maintainers want it after the ---.
> > The formatting of this patch also looks a bit odd. Did you use git
> > format-patch ; git send-email?
> Yes, I do git format-patch, then ./scripts/checkpatch.pl.
> Lastly git send-email
What looked odd is the missing --- marker. git format-patch should of
create that as part of the patch.