Re: [RFC PATCH 1/9] sched,cgroup: Add interface for latency-nice

From: Peter Zijlstra
Date: Thu Sep 05 2019 - 06:49:03 EST


On Thu, Sep 05, 2019 at 11:05:18AM +0100, Patrick Bellasi wrote:
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index b52ed1a..365c928 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -143,6 +143,13 @@ static inline void cpu_load_update_active(struct rq *this_rq) { }
> > #define NICE_0_LOAD (1L << NICE_0_LOAD_SHIFT)
> >
> > /*
> > + * Latency-nice default value
> > + */
> > +#define LATENCY_NICE_DEFAULT 5
> > +#define LATENCY_NICE_MIN 1
> > +#define LATENCY_NICE_MAX 100
>
> Values 1 and 5 looks kind of arbitrary.

Yes, and like I just wrote, completely and utterly wrong.