Re: [PATCH 1/2] staging: dt-bindings: wilc1000: add optional rtc_clk property
Date: Thu Sep 05 2019 - 07:35:02 EST
On 05-Sep-19 1:07 PM, Greg KH wrote:
> On Thu, Sep 05, 2019 at 06:09:43AM +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote:
>> Hi Eugen,
>> On 04-Sep-19 7:03 PM, Eugen Hristev - M18282 wrote:
>>> From: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
>>> Add bindings for optional rtc clock pin.
>>> Signed-off-by: Eugen Hristev <eugen.hristev@xxxxxxxxxxxxx>
>> Thanks for sending the patch series. The changes in this series looks
>> good to me.
>> Acked-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
> This is good, but, you are adding new features to the driver, when it is
> still in the staging directory. What's the plan on getting it out of
> here? What is left to do?
The plan is to get this driver reviewed and identify if there are any
more TODO items. Waiting for the review to complete.
During the last review , we have received comment to simplify the
packing of WID commands by avoiding the translation layer. We had done
some improvements in this but still, there are few items under discussion.
But I am not sure if this is a blocker for mainline or can be addressed
At this time, I don't know if there are any more TODO for this driver.
Currently also working on testing and fixing bugs.