Re: "fs/namei.c: keep track of nd->root refcount status" causes boot panic
From: Kevin Easton
Date: Thu Sep 05 2019 - 08:27:18 EST
On Tue, Sep 03, 2019 at 06:56:10PM +0100, Al Viro wrote:
> On Tue, Sep 03, 2019 at 08:39:30AM -0700, Christoph Hellwig wrote:
> > > There's much nastier situation than "new upstream kernel released,
> > > need to rebuild" - it's bisect in mainline trying to locate something...
> > I really don't get the point. And it's not like we've card about
> > this anywhere else. And jumping wildly around with the numeric values
> > for constants will lead to bugs like the one you added and fixed again
> > and again.
> The thing is, there are several groups - it's not as if all additions
> were guaranteed to be at the end. So either we play with renumbering
> again and again, or we are back to the square one...
> Is there any common trick that would allow to verify the lack of duplicates
> at the build time?
, "duplicated LOOKUP_* constant");