Re: [PATCH] i2c: muxes: pca9541: use BIT() macro

[Guenter Roeck]

On Thu, Sep 05, 2019 at 09:15:36PM +0530, Saiyam Doshi wrote:
> On Thu, Sep 05, 2019 at 06:21:06AM -0700, Guenter Roeck wrote:
> > linux/bitops.h should be included when using BIT().
> 
> It's included from linux/i2c-mux.h and it compiled successfully.
> But if it's needed I'll update the patch and resend.
> 
> Just a question - What is the best practice in such case? Should the 
> header included explicitly?
> 

process/submit-checklist.rst says, as very first point:

1) If you use a facility then #include the file that defines/declares
   that facility.  Don't depend on other header files pulling in ones
   that you use.

Guenter