Re: [PATCH 2/9] perf/core: Add PERF_SAMPLE_CGROUP feature

From: Tejun Heo
Date: Thu Sep 05 2019 - 12:57:00 EST


Hello, Namhyung.

On Tue, Sep 03, 2019 at 10:13:08AM +0800, Namhyung Kim wrote:
> So is my understanding below correct?
>
> * currently kernfs ino+gen is different than inode's ino+gen

They're the same. It's just that cgroup has other less useful IDs
too.

> * but it'd be better to make them same
> * so move (generic?) inode's ino+gen logic to cgroup
> * and kernfs node use the same logic (and number)
> * so perf sampling code (NMI) just access kernfs node
> * and userspace can use file handle for comparison

The rest, yes, pretty much.

Thanks.

--
tejun