Re: [PATCH 1/3] regulator: fixed: add possibility to enable by clock
From: Mark Brown
Date: Thu Sep 05 2019 - 14:06:24 EST
On Tue, Sep 03, 2019 at 08:03:46AM +0000, Philippe Schenker wrote:
> This commit adds the possibility to choose the compatible
> "regulator-fixed-clock" in devicetree.
> This is a special regulator-fixed that has to have a clock, from which
> the regulator gets switched on and off.
This seems conceptually fine. Minor issues though:
> +static int reg_clock_is_enabled(struct regulator_dev *rdev)
> + struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
> + if (priv->clk_enable_counter > 0)
> + return 1;
> + return 0;
This could just be return priv->clk_enable_counter > 0 - ideally the
clock API would let us query if the clock is enabled but that might be a
bit confused anyway given that it's possibly shared.
Description: PGP signature