Re: [PATCH 4.4 06/77] ASoC: Fail card instantiation if DAI format setup fails

From: Greg Kroah-Hartman
Date: Thu Sep 05 2019 - 14:56:54 EST


On Wed, Sep 04, 2019 at 07:09:52PM +0100, Mark Brown wrote:
> On Wed, Sep 04, 2019 at 07:52:53PM +0200, Greg Kroah-Hartman wrote:
> > [ Upstream commit 40aa5383e393d72f6aa3943a4e7b1aae25a1e43b ]
> >
> > If the DAI format setup fails, there is no valid communication format
> > between CPU and CODEC, so fail card instantiation, rather than continue
> > with a card that will most likely not function properly.
>
> I nacked this patch when Sasha posted it - it only improves diagnostics
> and might make systems that worked by accident break since it turns
> things into a hard failure, it won't make anything that didn't work
> previously work.

Now dropped.