Re: [PATCH] Bluetooth: hidp: Fix assumptions on the return value of hidp_send_message

From: Marcel Holtmann
Date: Fri Sep 06 2019 - 09:57:27 EST


Hi Jiri,

>> hidp_send_message was changed to return non-zero values on success,
>> which some other bits did not expect. This caused spurious errors to be
>> propagated through the stack, breaking some drivers, such as hid-sony
>> for the Dualshock 4 in Bluetooth mode.
>>
>> As pointed out by Dan Carpenter, hid-microsoft directly relied on that
>> assumption as well.
>>
>> Fixes: 48d9cc9d85dd ("Bluetooth: hidp: Let hidp_send_message return number of queued bytes")
>>
>> Signed-off-by: Dan Elkouby <streetwalkermc@xxxxxxxxx>
>
> Reviewed-by: Jiri Kosina <jkosina@xxxxxxx>
>
> Marcel, are you taking this through your tree?

I am taking this through my tree. And yes, I applied the updated patch, but answered the other ;)

Regards

Marcel