Re: [PATCH v6 4/4] tpm: tpm_tis_spi: Support cr50 devices
From: Jarkko Sakkinen
Date: Sat Sep 07 2019 - 13:04:25 EST
On Tue, 2019-09-03 at 09:52 -0700, Stephen Boyd wrote:
> That's fair. I'll put the Kconfig option back. There's still the small
> issue of what to do about the module name. Should I rename the
> tpm_tis_spi.c file to something else so that the module can keep the
> same name? Or was the tpm_tis_spi_mod.ko trick from v5 good enough?
Not sure I understood the question correctly but how I think
this should be deployed is:
- A boolean CONFIG_TCG_TIS_SPI_CR50.
- tpm_tis_spi_cr50.c that gets compiled in as part of tpm_tis_spi
when the config option is selected.
I think this would best follow the conventions that are in place
already. Please tell if I got something wrong or if there is some
bottleneck in this framework but this is anyway what I would prefer
with the knowledge I have...