Re: [PATCH v2 0/9] tools-power-x86-intel-speed-select: Fixes and updates for output

From: Andy Shevchenko
Date: Sat Sep 07 2019 - 14:15:15 EST


On Fri, Sep 6, 2019 at 10:58 AM Srinivas Pandruvada
<srinivas.pandruvada@xxxxxxxxxxxxxxx> wrote:
>
> On Thu, 2019-09-05 at 08:03 -0400, Prarit Bhargava wrote:
> > Some general fixes and updates for intel-speed-select. Fixes include
> > some
> > typos as well as an off-by-one cpu count reporting error. Updates
> > for the
> > output are
> >
> > - switching to MHz as a standard
> > - reporting CPU frequencies instead of ratios as a standard
> > - viewing a human-readable CPU list.
> > - avoiding reporting "0|1" as success|fail as these can be confusing
> > for a
> > user.
> >
> > v2: Add additional patch to fix memory leak and remove help text in
> > 8/9.
>
> For the series
>
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
>

Pushed to my review and testing queue, thanks!


> >
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > Cc: David Arcari <darcari@xxxxxxxxxx>
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> >
> > Prarit Bhargava (9):
> > tools/power/x86/intel-speed-select: Fix package typo
> > tools/power/x86/intel-speed-select: Fix help option typo
> > tools/power/x86/intel-speed-select: Fix cpu-count output
> > tools/power/x86/intel-speed-select: Simplify output for turbo-freq
> > and
> > base-freq
> > tools/power/x86/intel-speed-select: Switch output to MHz
> > tools/power/x86/intel-speed-select: Change turbo ratio output to
> > maximum turbo frequency
> > tools/power/x86/intel-speed-select: Output human readable CPU list
> > tools/power/x86/intel-speed-select: Output success/failed for
> > command
> > output
> > tools/power/x86/intel-speed-select: Fix memory leak
> >
> > .../x86/intel-speed-select/isst-config.c | 21 +--
> > .../x86/intel-speed-select/isst-display.c | 120 +++++++++++++---
> > --
> > 2 files changed, 98 insertions(+), 43 deletions(-)
> >
>


--
With Best Regards,
Andy Shevchenko