Re: crypto: caam - Cast to long first before pointer conversion
From: Horia Geanta
Date: Mon Sep 09 2019 - 07:07:01 EST
On 9/9/2019 10:46 AM, Herbert Xu wrote:
> On Tue, Sep 03, 2019 at 07:35:07PM -0700, Andrey Smirnov wrote:
>> With IRQ requesting being managed by devres we need to make sure that
>> we dispose of IRQ mapping after and not before it is free'd (otherwise
>> we'll end up with a warning from the kernel). To achieve that simply
>> convert IRQ mapping to rely on devres as well.
>> Fixes: f314f12db65c ("crypto: caam - convert caam_jr_init() to use devres")
>> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
>> Cc: Chris Healy <cphealy@xxxxxxxxx>
>> Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>> Cc: Horia Geantă <horia.geanta@xxxxxxx>
>> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
>> Cc: Iuliana Prodan <iuliana.prodan@xxxxxxx>
>> Cc: linux-crypto@xxxxxxxxxxxxxxx
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> drivers/crypto/caam/jr.c | 14 ++++++++++----
>> 1 file changed, 10 insertions(+), 4 deletions(-)
> I needed to apply this on top of it to shut up the compiler:
> While storing an int in a pointer is safe the compiler is not
> happy about it. So we need some extra casting in order to make
> this warning free.
> Fixes: 1d3f75bce123 ("crypto: caam - dispose of IRQ mapping only...")
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Indeed, this is needed for silencing compilation on ARM64
(while compiling for ARM works fine).
Reviewed-by: Horia Geantă <horia.geanta@xxxxxxx>
for the squashed patches.