Re: [PATCH 2/2] export.h, genksyms: do not make genksyms calculate CRC of trimmed symbols

From: Arnd Bergmann
Date: Mon Sep 09 2019 - 09:43:48 EST

On Mon, Sep 9, 2019 at 12:53 PM Masahiro Yamada
<yamada.masahiro@xxxxxxxxxxxxx> wrote:
> Since commit 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL*
> functions"), it is harmful because the bogus __crc* symbols make
> modpost call sym_update_crc(), and then new_symbol(), but there is
> no one that clears the ->is_static member.
> I gave Fixes to the first commit that uncovered the issue, but the
> potential problem has long existed since commit f235541699bc
> ("export.h: allow for per-symbol configurable EXPORT_SYMBOL()").
> Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions")
> Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Tested-by: Arnd Bergmann <arnd@xxxxxxxx>

Thanks for providing a proper fix!