Re: [PATCH] x86/umip: Add emulation for 64-bit processes

From: hpa
Date: Tue Sep 10 2019 - 02:33:17 EST


On September 10, 2019 7:28:28 AM GMT+01:00, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>* hpa@xxxxxxxxx <hpa@xxxxxxxxx> wrote:
>
>> I would strongly suggest that we change the term "emulation" to
>> "spoofing" for these instructions. We need to explain that we do
>*not*
>> execute these instructions the was the CPU would have, and unlike the
>
>> native instructions do not leak kernel information.
>
>Ok, I've edited the patch to add the 'spoofing' wording where
>appropriate, and I also made minor fixes such as consistently
>capitalizing instruction names.
>
>Can I also add your Reviewed-by tag?
>
>So the patch should show up in tip:x86/asm today-ish, and barring any
>complications is v5.4 material.
>
>Thanks,
>
> Ingo

Yes, please do.

Reviewed-by: H. Peter Anvin (Intel) <hpa@xxxxxxxxx>
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.