Re: [PATCH] net/mlx4_en: ethtool: make array modes static const, makes object smaller

From: David Miller
Date: Tue Sep 10 2019 - 04:29:41 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Fri, 6 Sep 2019 12:53:48 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Don't populate the array modes on the stack but instead make it
> static const. Makes the object code smaller by 303 bytes.
>
> Before:
> text data bss dec hex filename
> 51240 5008 1312 57560 e0d8 mellanox/mlx4/en_ethtool.o
>
> After:
> text data bss dec hex filename
> 50937 5008 1312 57257 dfa9 mellanox/mlx4/en_ethtool.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied to net-next.