Re: [PATCH v2] Staging: gasket: Use temporaries to reduce line length.
From: Dan Carpenter
Date: Tue Sep 10 2019 - 07:27:23 EST
On Tue, Sep 10, 2019 at 07:11:26AM +0200, Sandro Volery LKML wrote:
> Wow... I checked, compiled and still sent the wrong thing again. I'm
> gonna have to give this up soon if i can't get it right.
The mistake was using gasket_page_table_num_simple_entries() instead
When I write a patch, I always queue it up and the let it sit in my
outbox overnight so I can review it again in the morning. Otherwise my
mind is clouded with other emotions and I can't review objectively.
There is never a rush.
> Sandro V
> > On 10 Sep 2019, at 07:06, Sandro Volery <sandro@xxxxxxxxxx> wrote:
> > ïUsing temporaries for gasket_page_table entries to remove scnprintf()
> > statements and reduce line length, as suggested by Joe Perches. Thanks!
Don't put this in the commit log. :P