RE: linux-next: Signed-off-by missing for commit in the pci tree

From: Haiyang Zhang
Date: Tue Sep 10 2019 - 09:56:43 EST




> -----Original Message-----
> From: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> Sent: Tuesday, September 10, 2019 7:18 AM
> To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Cc: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>; Bjorn Helgaas
> <bhelgaas@xxxxxxxxxx>; Linux Next Mailing List <linux-
> next@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>
> Subject: Re: linux-next: Signed-off-by missing for commit in the pci tree
>
> On Mon, Sep 09, 2019 at 11:10:06PM +0000, Haiyang Zhang wrote:
> >
> >
> > > -----Original Message-----
> > > From: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> > > Sent: Wednesday, August 21, 2019 5:03 AM
> > > To: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>; Linux Next Mailing List
> > > <linux- next@xxxxxxxxxxxxxxx>; Linux Kernel Mailing List <linux-
> > > kernel@xxxxxxxxxxxxxxx>; Sasha Levin <sashal@xxxxxxxxxx>; Haiyang
> > > Zhang <haiyangz@xxxxxxxxxxxxx>
> > > Subject: Re: linux-next: Signed-off-by missing for commit in the pci
> > > tree
> > >
> > > On Wed, Aug 21, 2019 at 07:19:39AM +1000, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > Commit
> > > >
> > > > c4a29fbba415 ("PCI: hv: Use bytes 4 and 5 from instance ID as
> > > > the PCI
> > > domain numbers")
> > > >
> > > > is missing a Signed-off-by from its committer.
> > > >
> > > > Also, all the tags should be kept together, please.
> > >
> > > Fixed it up in my pci/hv branch, apologies.
> > >
> > > Lorenzo
> >
> > Hi thanks for fixing this, but I found the following commit now has
> > the Subject line and commit message same as a previous patch.
> >
> > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> > kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Fnext%2Flinux-
> next.git%
> >
> 2Fcommit%2Fdrivers%3Fid%3D87b20a08dcc265959f5c59f18603ea0487fe60
> 9b&amp
> > ;data=02%7C01%7Chaiyangz%40microsoft.com%7Cb4e2f03b09da4454342
> 108d735e
> >
> 081d0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C6370371106
> 95959451&
> >
> amp;sdata=17KZvmvtuHz3f0xKh6MwSOja41VerGTpyAO0f7BF6gY%3D&amp;r
> eserved=
> > 0
> >
> > The correct message for the patch should be the msg below. Any
> > possibility to fix it again? Thanks.
>
> I updated my pci/hv branch and rewrote the commit log, I will ask Bjorn to
> update it so that it shows up in -next.
>
> Lorenzo


Thank you!