Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.
From: Andreas Schwab
Date: Wed Sep 11 2019 - 03:31:17 EST
On Sep 11 2019, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> Hi Andreas,
> On Thu, Aug 15, 2019 at 12:37 AM Andreas Schwab <schwab@xxxxxxxxxxxxxx> wrote:
>> On Aug 14 2019, Palmer Dabbelt <palmer@xxxxxxxxxx> wrote:
>> > On Wed, 14 Aug 2019 13:32:50 PDT (-0700), Paul Walmsley wrote:
>> >> On Wed, 14 Aug 2019, Vincent Chen wrote:
>> >>> Make the __fstate_clean() function correctly set the
>> >>> state of sstatus.FS in pt_regs to SR_FS_CLEAN.
>> >>> Fixes: 7db91e5 ("RISC-V: Task implementation")
>> >>> Cc: linux-stable <stable@xxxxxxxxxxxxxxx>
>> >>> Signed-off-by: Vincent Chen <vincent.chen@xxxxxxxxxx>
>> >>> Reviewed-by: Anup Patel <anup@xxxxxxxxxxxxxx>
>> >>> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
>> >> Thanks, I extended the "Fixes" commit ID to 12 digits, as is the usual
>> >> practice here, and have queued the following for v5.3-rc.
>> > For reference, something like "git config core.abbrev=12" (or whatever you
>> > write to get this in your .gitconfig)
>> > https://github.com/palmer-dabbelt/home/blob/master/.gitconfig.in#L23
>> > causes git to do the right thing.
>> Actually, the right setting is core.abbrev=auto (or leaving it unset).
>> It lets git chose the appropriate length depending on the repository
>> contents. For the linux repository it will chose 13 right now.
> Does that depend on the git version?
> For me (git version 2.17.1), it still uses 12 when using the auto setting.
No, 12 is the correct number. I was miscounting.
Andreas Schwab, schwab@xxxxxxxxxxxxxx
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."