Re: [PATCH v2 00/11] mmc: core: PM fixes/improvements for SDIO IRQs
From: Ulf Hansson
Date: Wed Sep 11 2019 - 10:21:44 EST
On Sun, 8 Sep 2019 at 12:12, Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> Changes in v2:
> - Added reviewed/tested-by tags.
> - Updated some changelogs.
> - Renamed sdio_irq_enabled() to sdio_irq_claimed().
> - Don't set sdio_irq_pending when resuming SDIO card, but just queue the
> The power management support for SDIO cards have slowly been improved, but
> there are still quite some serious problems, especially when dealing with the
> so called SDIO IRQs during system suspend/resume.
> This series makes some additional improvements to this code in the mmc core,
> but also includes some needed adaptations for the sdhci, the dw_mmc and the
> mtk-sd host drivers.
> The series is also available at:
> git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git sdio_irq_suspend_next_v2
> Kind regards
> Matthias Kaehlcke (1):
> mmc: core: Move code to get pending SDIO IRQs to a function
> Ulf Hansson (10):
> mmc: core: Add helper function to indicate if SDIO IRQs is enabled
> mmc: dw_mmc: Re-store SDIO IRQs mask at system resume
> mmc: mtk-sd: Re-store SDIO IRQs mask at system resume
> mmc: core: Clarify sdio_irq_pending flag for
> mmc: core: Clarify that the ->ack_sdio_irq() callback is mandatory
> mmc: core: WARN if SDIO IRQs are enabled for non-powered card in
> mmc: core: Fixup processing of SDIO IRQs during system suspend/resume
> mmc: sdhci: Drop redundant check in sdhci_ack_sdio_irq()
> mmc: sdhci: Drop redundant code for SDIO IRQs
> mmc: sdhci: Convert to use sdio_irq_claimed()
> drivers/mmc/core/sdio.c | 4 ++-
> drivers/mmc/core/sdio_irq.c | 57 +++++++++++++++++++-----------
> drivers/mmc/host/dw_mmc.c | 4 +++
> drivers/mmc/host/mtk-sd.c | 3 ++
> drivers/mmc/host/sdhci-esdhc-imx.c | 34 ++++++++----------
> drivers/mmc/host/sdhci.c | 12 ++-----
> drivers/mmc/host/sdhci.h | 6 ----
> include/linux/mmc/host.h | 10 ++++++
> 8 files changed, 75 insertions(+), 55 deletions(-)
So, I have queued this up for next (using v3 of patch 3), thanks all
for reviewing and testing!