Re: [PATCH v2 4/4] coding-style: add explanation about pr_fmt macro

From: Chaitanya Kulkarni
Date: Fri Sep 13 2019 - 18:18:07 EST


I'm not super familier with the format, will let someone do the
final review.

In general looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>

On 09/13/2019 03:04 PM, André Almeida wrote:
> The pr_fmt macro is useful to format log messages printed by pr_XXXX()
> functions. Add text to explain the purpose of it, how to use and an
> example.
>
> Signed-off-by: André Almeida<andrealmeid@xxxxxxxxxxxxx>
> Cc: Jonathan Corbet<corbet@xxxxxxx>
> ---
> Changes from v1:
> - Add Jonathan as explict Cc
> - Replace "include/printk.h" by "#include <linux/kernel.h>
> - Add note about #undef
> - Replace hardcore string by KBUILD_MODNAME at the example
> ---