Re: [PATCH 4/4] x86: fix function types in COND_SYSCALL

From: Andy Lutomirski
Date: Fri Sep 13 2019 - 20:28:56 EST

> On Sep 13, 2019, at 4:28 PM, Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
>> On Fri, Sep 13, 2019 at 3:46 PM Andy Lutomirski <luto@xxxxxxxxxx> wrote:
>> Didn't you just fix the type of sys_ni_syscall? What am I missing here?
> The other patch fixes indirect call type mismatches when the function
> is called through the syscall table. However, cond_syscall creates an
> alias to the actual sys_ni_syscall function defined in
> kernel/sys_ni.c, which still has the wrong type.

Ah, I get it. Doesnât this cause a little bit of code bloat, though? What if you made __x86_ni_syscall, etc (possibly using the *DEFINE_SYSCALL0 macros) and then generate weak aliases to those?