Re: [PATCH v2] net: mdio: switch to using gpiod_get_optional()
From: Andy Shevchenko
Date: Sun Sep 15 2019 - 07:14:35 EST
On Sun, Sep 15, 2019 at 9:26 AM Dmitry Torokhov
> On Sat, Sep 14, 2019 at 08:09:33PM +0300, Andy Shevchenko wrote:
> > On Fri, Sep 13, 2019 at 03:55:47PM -0700, Dmitry Torokhov wrote:
> > > + mdiodev->reset_gpio = gpiod_get_optional(&mdiodev->dev,
> > > + "reset", GPIOD_OUT_LOW);
> > > + error = PTR_ERR_OR_ZERO(mdiodev->reset_gpio);
> > > + if (error)
> > > + return error;
> > > + if (mdiodev->reset_gpio)
> > This is redundant check.
> I see that gpiod_* API handle NULL desc and usually return immediately,
> but frankly I am not that comfortable with it. I'm OK with functions
> that free/destroy objects that recognize NULL resources,
> but it is
> unusual for other types of APIs.
CLK, reset, ... frameworks do check for NULL pointer since they
provide an *_optional() getters. So, it's not unusual.
With Best Regards,