Re: Linux 5.3-rc8

From: Linus Torvalds
Date: Sun Sep 15 2019 - 12:30:50 EST

On Sat, Sep 14, 2019 at 11:51 PM Lennart Poettering
<mzxreary@xxxxxxxxxxx> wrote:
> Oh man. Just spend 5min to understand the situation, before claiming
> this was garbage or that was garbage. The code above does not block
> boot.

Yes it does. You clearly didn't read the thread.

> It blocks startup of services that explicit order themselves
> after the code above. There's only a few services that should do that,
> and the main system boots up just fine without waiting for this.

That's a nice theory, but it doesn't actually match reality.

There are clearly broken setups that use this for things that it
really shouldn't be used for. Asking for true randomness at boot
before there is any indication that randomness exists, and then just
blocking with no further action that could actually _generate_ said

If your description was true that the system would come up and be
usable while the blocked thread is waiting for that to happen, things
would be fine.

But that simply isn't the case.