Re: [PATCH 2/2] dt-bindings: net: dwmac: document 'mac-mode' property

[Ardelean, Alexandru]

On Fri, 2019-09-13 at 15:36 +0100, Rob Herring wrote:
> [External]
> 
> On Fri, Sep 06, 2019 at 04:02:56PM +0300, Alexandru Ardelean wrote:
> > This change documents the 'mac-mode' property that was introduced in the
> > 'stmmac' driver to support passive mode converters that can sit in-between
> > the MAC & PHY.
> > 
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/net/snps,dwmac.yaml | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index c78be15704b9..ebe4537a7cce 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -112,6 +112,14 @@ properties:
> >    reset-names:
> >      const: stmmaceth
> >  
> > +  mac-mode:
> > +    maxItems: 1
> 
> Is this an array because {min,max}Items is for arrays? It should be 
> defined as a string with possible values.
> 
> As this property is the same as another, you can do this:
> 
> $ref: ethernet-controller.yaml#/properties/phy-connection-type
> 
> Unless only a small subset of those values are valid here, then you may 
> want to list them here.
> 

Ack.
Thank you.

Will investigate and re-spin.


> > +    description:
> > +      The property is identical to 'phy-mode', and assumes that there is mode
> > +      converter in-between the MAC & PHY (e.g. GMII-to-RGMII). This converter
> > +      can be passive (no SW requirement), and requires that the MAC operate
> > +      in a different mode than the PHY in order to function.
> > +
> >    snps,axi-config:
> >      $ref: /schemas/types.yaml#definitions/phandle
> >      description:
> > -- 
> > 2.20.1
> >